Review Request: Bugfix Signature Assistant, add tests

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106667/#review19935
-----------------------------------------------------------

Ship it!


Looks like solid, clean work - great! Are you confident (with these unit tests) to push this into 1.4.0? Or would you rather wait until 1.4.1?

Cheers

- Milian Wolff


On Oct. 1, 2012, 1:22 p.m., Olivier Jean de Gaalon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106667/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2012, 1:22 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Fix signature assistant default argument assignment, add tests (also for renameAssistant).
> Note that the tests require a patch to kdevplatform to disable the source formatter.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codegen/codeassistant.h d4284a2 
>   languages/cpp/codegen/renameaction.h 5455777 
>   languages/cpp/codegen/renameaction.cpp 0336100 
>   languages/cpp/codegen/signatureassistant.cpp 4447572 
>   languages/cpp/tests/CMakeLists.txt 24d9597 
>   languages/cpp/tests/test_cppassistants.h PRE-CREATION 
>   languages/cpp/tests/test_cppassistants.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/106667/diff/
> 
> 
> Testing
> -------
> 
> Lots.
> 
> 
> Thanks,
> 
> Olivier Jean de Gaalon
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121004/923b0ec4/attachment.html>