Review Request: Bugfix Signature Assistant, add tests

Olivier Jean de Gaalon olivier.jg at gmail.com
Mon Oct 1 13:22:46 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106667/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

Fix signature assistant default argument assignment, add tests (also for renameAssistant).
Note that the tests require a patch to kdevplatform to disable the source formatter.


Diffs
-----

  languages/cpp/codegen/codeassistant.h d4284a2 
  languages/cpp/codegen/renameaction.h 5455777 
  languages/cpp/codegen/renameaction.cpp 0336100 
  languages/cpp/codegen/signatureassistant.cpp 4447572 
  languages/cpp/tests/CMakeLists.txt 24d9597 
  languages/cpp/tests/test_cppassistants.h PRE-CREATION 
  languages/cpp/tests/test_cppassistants.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/106667/diff/


Testing
-------

Lots.


Thanks,

Olivier Jean de Gaalon

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121001/d9199eab/attachment.html>


More information about the KDevelop-devel mailing list