Review Request: Fixed GPF for CMake string() commands with incorrect argument count

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106673/#review19868
-----------------------------------------------------------


Hi Michal!
Maybe you can add some unit tests in the cmakeast_test.cpp file, so that we can make sure this won't happen in the future?

Thanks for the patch!

- Aleix Pol Gonzalez


On Oct. 1, 2012, 4:32 p.m., Michal Malek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106673/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2012, 4:32 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> CMake project manager parser doesn't check number of arguments when it parses string() function with commands CONFIGURE, TOUPPER, TOLOWER and LENGTH. This results in GPF when for some reason too few arguments is provided for these commands. This patch adds missing checks.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/parser/cmakeast.cpp bff718c618669370aad8856673ef584e60e3c314 
> 
> Diff: http://git.reviewboard.kde.org/r/106673/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Malek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121004/7ef859df/attachment.html>