<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106673/">http://git.reviewboard.kde.org/r/106673/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Michal!
Maybe you can add some unit tests in the cmakeast_test.cpp file, so that we can make sure this won't happen in the future?
Thanks for the patch!</pre>
<br />
<p>- Aleix</p>
<br />
<p>On October 1st, 2012, 4:32 p.m., Michal Malek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Michal Malek.</div>
<p style="color: grey;"><i>Updated Oct. 1, 2012, 4:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">CMake project manager parser doesn't check number of arguments when it parses string() function with commands CONFIGURE, TOUPPER, TOLOWER and LENGTH. This results in GPF when for some reason too few arguments is provided for these commands. This patch adds missing checks.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>projectmanagers/cmake/parser/cmakeast.cpp <span style="color: grey">(bff718c618669370aad8856673ef584e60e3c314)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106673/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>