Review Request: Correct parsing ot add_test cmake function
Commit Hook
null at kde.org
Sun Nov 25 17:10:33 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107454/#review22518
-----------------------------------------------------------
This review has been submitted with commit 9c4a42a27277e921560f4b8b54b681fc6fa4b246 by Sergey Vidyuk to branch master.
- Commit Hook
On Nov. 24, 2012, 9:42 p.m., Sergey Vidyuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107454/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2012, 9:42 p.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> There are 2 different call semantic for this function:
> * add_test(TestName ExeName Args...)
> * add_test(NAME TestName [extra switches] COMMAND ExeName Args...)
> Correct parsing of the second variant is added. Unit tests modified to
> check this fix.
>
>
> Diffs
> -----
>
> projectmanagers/cmake/parser/cmakeast.cpp b07008c
> projectmanagers/cmake/tests/cmakeast_test.cpp 115ed2b
>
> Diff: http://git.reviewboard.kde.org/r/107454/diff/
>
>
> Testing
> -------
>
> * Run modified unit tests successfully.
> * Run KDevelp unit tests using Run all tests feature manually
>
>
> Thanks,
>
> Sergey Vidyuk
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121125/e74473ac/attachment.html>
More information about the KDevelop-devel
mailing list