Review Request: Correct parsing ot add_test cmake function

Sergey Vidyuk sir.vestnik at gmail.com
Sat Nov 24 21:42:30 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107454/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

There are 2 different call semantic for this function:
 * add_test(TestName ExeName Args...)
 * add_test(NAME TestName [extra switches] COMMAND ExeName Args...)
Correct parsing of the second variant is added. Unit tests modified to
check this fix.


Diffs
-----

  projectmanagers/cmake/parser/cmakeast.cpp b07008c 
  projectmanagers/cmake/tests/cmakeast_test.cpp 115ed2b 

Diff: http://git.reviewboard.kde.org/r/107454/diff/


Testing
-------

 * Run modified unit tests successfully.
 * Run KDevelp unit tests using Run all tests feature manually


Thanks,

Sergey Vidyuk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121124/6f3f91be/attachment.html>


More information about the KDevelop-devel mailing list