Review Request: Segfault when opening project configuration for kdev-python project

David Knapp psychicsurgeon at gmail.com
Sun Nov 11 06:12:49 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107291/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

Fixes a segfault crash due to a null pointer exception when opening the project configuration for a kdev-python project. The docs for IProject::buildSystemManager() says "@return the build system manager for the project, if one exists; otherwise null". The code previously however relied on that call returning a non-null pointer.


Diffs
-----

  shell/projectcontroller.cpp 6168066 

Diff: http://git.reviewboard.kde.org/r/107291/diff/


Testing
-------

I can now open a config window for my python project


Thanks,

David Knapp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121111/a8522306/attachment.html>


More information about the KDevelop-devel mailing list