Review Request: Improve appearance of assistant popup in language support

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107277/#review21823
-----------------------------------------------------------


The idea back then was to show that action as unobtrusive as possible. The way you have it now is pretty much in-your-face.

I agree of course that there are problems with the existing solution, esp. when you either edit near the bottom of the document, or if you change
something with multiple (long) options. Still, I'm not sure whether your way is optimal either...

Your implementation is esp. broken when you scroll the view while the popup is shown, as its position is not properly updated then.

I think I'll play a bit with it and see what I can come up with.

Cheers


- Milian Wolff


On Nov. 10, 2012, 1:25 p.m., André Stein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107277/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 1:25 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> I improved (at least IMO) the appearance of the assistant popup while editing code:
> - I changed the layout of the popup to be vertically. Sometimes there are many actions in the popup which gives a rather crowded look. Additionally it sometimes doesn't fit on small screens (at least not on my 13" notebook).
> - The placement has been changed to be oriented at the current cursor's position. The popup is placed 2 lines _under_ the currently edited line. If a line is edited at the bottom of the editor and the popup wouldn't fit into the window, it is placed _above_ the current line. That way a nasty magic number in the code can be removed too.
> 
> All in all I think this gives a better user experience. I had the feeling that some users didn't even see the popup because it was placed at the editor's bottom and so was out of the current "code focus". Additionally the vertical layout matches the behaviour which is seen in other IDEs like Qt Creator or Eclipse.
> 
> 
> Diffs
> -----
> 
>   shell/assistantpopup.h 42c55e4 
>   shell/assistantpopup.cpp 44a4538 
>   shell/uicontroller.cpp 2c0400f 
> 
> Diff: http://git.reviewboard.kde.org/r/107277/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Screenshots
> -----------
> 
> Popup under code
>   http://git.reviewboard.kde.org/r/107277/s/817/
> Popup when space is limited (above)
>   http://git.reviewboard.kde.org/r/107277/s/818/
> 
> 
> Thanks,
> 
> André Stein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121111/bd8dc6f2/attachment.html>