Review Request: Improve appearance of assistant popup in language support

[André Stein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107277/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

I improved (at least IMO) the appearance of the assistant popup while editing code:
- I changed the layout of the popup to be vertically. Sometimes there are many actions in the popup which gives a rather crowded look. Additionally it sometimes doesn't fit on small screens (at least not on my 13" notebook).
- The placement has been changed to be oriented at the current cursor's position. The popup is placed 2 lines _under_ the currently edited line. If a line is edited at the bottom of the editor and the popup wouldn't fit into the window, it is placed _above_ the current line. That way a nasty magic number in the code can be removed too.

All in all I think this gives a better user experience. I had the feeling that some users didn't even see the popup because it was placed at the editor's bottom and so was out of the current "code focus". Additionally the vertical layout matches the behaviour which is seen in other IDEs like Qt Creator or Eclipse.


Diffs
-----

  shell/assistantpopup.h 42c55e4 
  shell/assistantpopup.cpp 44a4538 
  shell/uicontroller.cpp 2c0400f 

Diff: http://git.reviewboard.kde.org/r/107277/diff/


Testing
-------

Manual testing.


Screenshots
-----------

Popup under code
  http://git.reviewboard.kde.org/r/107277/s/817/
Popup when space is limited (above)
  http://git.reviewboard.kde.org/r/107277/s/818/


Thanks,

André Stein

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121110/19aa290e/attachment.html>