Review Request: Prevent potential crash in kompareprocess

[André Stein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107270/
-----------------------------------------------------------

(Updated Nov. 10, 2012, 10 a.m.)


Review request for KDevelop.


Changes
-------

After some investigation I saw that m_diffSettings can never be null. In Kdevelop at least it is always assured that a valid pointer is passed to KompareProcess. So I updated the diff to include an assertion so that any static tools won't trigger a false alarm.


Description
-------

This patch prevents a null pointer dereference in kompareprocess.


Diffs (updated)
-----

  plugins/patchreview/libdiff2/kompareprocess.cpp fe9a62e 

Diff: http://git.reviewboard.kde.org/r/107270/diff/


Testing
-------


Thanks,

André Stein

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121110/b1a09e07/attachment.html>