Review Request: Prevent potential crash in kompareprocess

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107270/#review21761
-----------------------------------------------------------



plugins/patchreview/libdiff2/kompareprocess.cpp
<http://git.reviewboard.kde.org/r/107270/#comment16827>

    This is not correct, it changes the behaviour. The original code would also add the -U argument when m_diffSettings is not null, but the diff-program is empty. That should be preserved IMHO. So a separate check on the pointer should be added around the last line instead of making it part of the existing else.


- Andreas Pakulat


On Nov. 9, 2012, 11:12 p.m., André Stein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107270/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2012, 11:12 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This patch prevents a null pointer dereference in kompareprocess.
> 
> 
> Diffs
> -----
> 
>   plugins/patchreview/libdiff2/kompareprocess.cpp fe9a62e 
> 
> Diff: http://git.reviewboard.kde.org/r/107270/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> André Stein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121110/7b496137/attachment.html>