Review Request: Add a document list context menu button right to main tab bar

[André Stein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107170/
-----------------------------------------------------------

(Updated Nov. 6, 2012, 2:14 p.m.)


Review request for KDevelop.


Changes
-------

I updated the diff:
- A ToolButton is now used instead of a PushButton. It takes less space. Additionally the arrow has been removed (see screen shot)-
- A tool tip has been added which explains what this button does
- The list is now sorted case insensitively
- I didn't implement QMap yet for two reasons:
  1. I think it's a premature optimization. The Add and Remove widgets functions are just called a few times. But organizing a map would introduce more complexity. Especially when removing a widget the QMap must then be searched linearly for the value.
  2. The QAction items have to be recreated anyway because just adding or removing the relevant actions would be too complex for little gain. So all in all I don't think that a QMap would bring us a great benefit here.


Description
-------

This request adds a little button to the right of the tab bar. It activates a context menu which shows (in sorted order) all currently open documents and opens the selected document upon click. This is a feature I miss from Visual Studio. I do know that it's redundant to the Documents view panel but I think it allows a quicker access to files - especially when a lot files are open in the IDE. As it is very small button I think it does no harm to users who don't want to use it.


Diffs (updated)
-----

  sublime/container.h 1633a9f 
  sublime/container.cpp 5483029 

Diff: http://git.reviewboard.kde.org/r/107170/diff/


Testing
-------

Manual testing.


Screenshots (updated)
-----------

Context menu shown on button click
  http://git.reviewboard.kde.org/r/107170/s/809/
Button
  http://git.reviewboard.kde.org/r/107170/s/814/


Thanks,

André Stein

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121106/ede6e11a/attachment.html>