<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107170/">http://git.reviewboard.kde.org/r/107170/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By André Stein.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2012, 2:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I updated the diff:
- A ToolButton is now used instead of a PushButton. It takes less space. Additionally the arrow has been removed (see screen shot)-
- A tool tip has been added which explains what this button does
- The list is now sorted case insensitively
- I didn't implement QMap yet for two reasons:
1. I think it's a premature optimization. The Add and Remove widgets functions are just called a few times. But organizing a map would introduce more complexity. Especially when removing a widget the QMap must then be searched linearly for the value.
2. The QAction items have to be recreated anyway because just adding or removing the relevant actions would be too complex for little gain. So all in all I don't think that a QMap would bring us a great benefit here.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This request adds a little button to the right of the tab bar. It activates a context menu which shows (in sorted order) all currently open documents and opens the selected document upon click. This is a feature I miss from Visual Studio. I do know that it's redundant to the Documents view panel but I think it allows a quicker access to files - especially when a lot files are open in the IDE. As it is very small button I think it does no harm to users who don't want to use it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>sublime/container.h <span style="color: grey">(1633a9f)</span></li>
<li>sublime/container.cpp <span style="color: grey">(5483029)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107170/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots (updated)</h1>
<div>
<a href="http://git.reviewboard.kde.org/r/107170/s/809/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/01/documentlist2_400x100.png" style="border: 1px black solid;" alt="Context menu shown on button click" /></a>
<a href="http://git.reviewboard.kde.org/r/107170/s/814/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/11/06/kdev_400x100.png" style="border: 1px black solid;" alt="Button" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>