Review Request: Add a document list context menu button right to main tab bar

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107170/#review21347
-----------------------------------------------------------



sublime/container.cpp
<http://git.reviewboard.kde.org/r/107170/#comment16618>

    considering that this is called whenever you open/close a document, this should not resort the stuff over and over again. Make the sorted QMap (see comment blow) a class member and update it as required.



sublime/container.cpp
<http://git.reviewboard.kde.org/r/107170/#comment16619>

    will this also delete the actions? if not, do that manually using qDeleteAll



sublime/container.cpp
<http://git.reviewboard.kde.org/r/107170/#comment16615>

    Just use QMap<QString, QWidget*> - it will be sorted automatically



sublime/container.cpp
<http://git.reviewboard.kde.org/r/107170/#comment16616>

    use QVariant::formValue(pair.second) (or the proper analogon once you ported to QMap).
    
    QWidget* should be a registered meta type, if not - register it. Do not use void*.



sublime/container.cpp
<http://git.reviewboard.kde.org/r/107170/#comment16617>

    this really looks wrong in the UI, you get two arrows which just looks broken. Have you tried with an empty string?
    
    Also make sure to add a tooltip that explains what this is doing.



sublime/container.cpp
<http://git.reviewboard.kde.org/r/107170/#comment16620>

    action->data().value<QWidget*>() should work, if not - make it so.


- Milian Wolff


On Nov. 1, 2012, 4:36 p.m., André Stein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107170/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2012, 4:36 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This request adds a little button to the right of the tab bar. It activates a context menu which shows (in sorted order) all currently open documents and opens the selected document upon click. This is a feature I miss from Visual Studio. I do know that it's redundant to the Documents view panel but I think it allows a quicker access to files - especially when a lot files are open in the IDE. As it is very small button I think it does no harm to users who don't want to use it.
> 
> 
> Diffs
> -----
> 
>   sublime/container.h 1633a9f 
>   sublime/container.cpp 5483029 
> 
> Diff: http://git.reviewboard.kde.org/r/107170/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Screenshots
> -----------
> 
> Button
>   http://git.reviewboard.kde.org/r/107170/s/808/
> Context menu shown on button click
>   http://git.reviewboard.kde.org/r/107170/s/809/
> 
> 
> Thanks,
> 
> André Stein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20121102/858d2e8d/attachment.html>