Review Request: Make area switcher usable when KDevelop runs on an appmenu-enabled system

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105116/#review14297
-----------------------------------------------------------

Ship it!


Looks good to me now.

- Aleix Pol Gonzalez


On May 31, 2012, 1:15 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105116/
> -----------------------------------------------------------
> 
> (Updated May 31, 2012, 1:15 p.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Description
> -------
> 
> When running on an appmenu-enabled system, one cannot add widgets in the menubar corner. This patch detects this (by checking QMenuBar::isNativeMenuBar()) and creates an action to hold the area switcher widget in this case. KDevelop itself needs a simple patch to integrate this action in its main toolbar (see https://git.reviewboard.kde.org/r/105117/ ).
> 
> 
> Diffs
> -----
> 
>   shell/uicontroller.h a800f00 
>   shell/uicontroller.cpp 11fdf75 
>   sublime/mainwindow.h 2656624 
>   sublime/mainwindow.cpp 3f424f8 
>   sublime/mainwindow_p.h 12814a0 
>   sublime/mainwindow_p.cpp 87fb45e 
> 
> Diff: http://git.reviewboard.kde.org/r/105116/diff/
> 
> 
> Testing
> -------
> 
> Tested with and without appmenu running. With appmenu the switcher appears on the left of the main toolbar, without appmenu it appears on the right of the menubar, as before.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120531/73f15c3e/attachment.html>