<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105116/">http://git.reviewboard.kde.org/r/105116/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me now.</pre>
<br />
<p>- Aleix</p>
<br />
<p>On May 31st, 2012, 1:15 p.m., Aurélien Gâteau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop and Aleix Pol Gonzalez.</div>
<div>By Aurélien Gâteau.</div>
<p style="color: grey;"><i>Updated May 31, 2012, 1:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When running on an appmenu-enabled system, one cannot add widgets in the menubar corner. This patch detects this (by checking QMenuBar::isNativeMenuBar()) and creates an action to hold the area switcher widget in this case. KDevelop itself needs a simple patch to integrate this action in its main toolbar (see https://git.reviewboard.kde.org/r/105117/ ).
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with and without appmenu running. With appmenu the switcher appears on the left of the main toolbar, without appmenu it appears on the right of the menubar, as before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>shell/uicontroller.h <span style="color: grey">(a800f00)</span></li>
<li>shell/uicontroller.cpp <span style="color: grey">(11fdf75)</span></li>
<li>sublime/mainwindow.h <span style="color: grey">(2656624)</span></li>
<li>sublime/mainwindow.cpp <span style="color: grey">(3f424f8)</span></li>
<li>sublime/mainwindow_p.h <span style="color: grey">(12814a0)</span></li>
<li>sublime/mainwindow_p.cpp <span style="color: grey">(87fb45e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105116/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>