Review Request: Improvements to the "Add Toolview" dialog.
Ghislain Mary
gmary at lunacymaze.org
Thu May 24 07:24:50 UTC 2012
> On May 23, 2012, 7:50 p.m., Milian Wolff wrote:
> > patch looks good - do you have commit rights? if not, please attach ("add file" menu) the patch as created by "git format-patch" and I'll upstream this.
> >
> > thanks!
No commit rights, I attached the formatted patch.
- Ghislain
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104818/#review14095
-----------------------------------------------------------
On May 24, 2012, 7:24 a.m., Ghislain Mary wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104818/
> -----------------------------------------------------------
>
> (Updated May 24, 2012, 7:24 a.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> Allow selecting multiple toolviews to be added in the dialog.
> Allow adding a toolview by double-clicking on it in the dialog.
> Disable toolviews that are already present in the current main window area to prevent adding the same toolview multiple times.
> Also disable toolviews that are already present in the current main window area in the dock area context menu.
>
>
> This addresses bug 165969.
> http://bugs.kde.org/show_bug.cgi?id=165969
>
>
> Diffs
> -----
>
> shell/mainwindow_actions.cpp e0610e9
> shell/mainwindow_p.cpp 18ca6b5
> shell/uicontroller.h 02ebd5c
> shell/uicontroller.cpp ad0e583
>
> Diff: http://git.reviewboard.kde.org/r/104818/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ghislain Mary
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120524/3e43419e/attachment.html>
More information about the KDevelop-devel
mailing list