Review Request: Improvements to the "Add Toolview" dialog.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104818/#review14095
-----------------------------------------------------------

Ship it!


patch looks good - do you have commit rights? if not, please attach ("add file" menu) the patch as created by "git format-patch" and I'll upstream this.

thanks!

- Milian Wolff


On May 16, 2012, 1:31 p.m., Ghislain Mary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104818/
> -----------------------------------------------------------
> 
> (Updated May 16, 2012, 1:31 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Allow selecting multiple toolviews to be added in the dialog.
> Allow adding a toolview by double-clicking on it in the dialog.
> Disable toolviews that are already present in the current main window area to prevent adding the same toolview multiple times.
> Also disable toolviews that are already present in the current main window area in the dock area context menu.
> 
> 
> This addresses bug 165969.
>     http://bugs.kde.org/show_bug.cgi?id=165969
> 
> 
> Diffs
> -----
> 
>   shell/mainwindow_actions.cpp e0610e9 
>   shell/mainwindow_p.cpp 18ca6b5 
>   shell/uicontroller.h 02ebd5c 
>   shell/uicontroller.cpp ad0e583 
> 
> Diff: http://git.reviewboard.kde.org/r/104818/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ghislain Mary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120523/c9af2c53/attachment.html>