Review Request: Let __builtin_offsetof be used with "struct foo" as type
Commit Hook
null at kde.org
Tue May 22 08:30:58 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104912/#review14029
-----------------------------------------------------------
This review has been submitted with commit f70f909c636058c71c37aa35243f816dbc3d726d by Alexandre Courbot to branch master.
- Commit Hook
On May 14, 2012, 1:34 a.m., Alexandre Courbot wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104912/
> -----------------------------------------------------------
>
> (Updated May 14, 2012, 1:34 a.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> There is a clever macro defined that supports __builtin_offset, but constructs of the form "__builtin_offset(struct foo, member)" would fail with a parse error. This patch adds parentheses around the type to ensure these are supported as well.
>
>
> Diffs
> -----
>
> languages/cpp/setuphelpers.cpp 23d549e
> languages/cpp/tests/test_cppcodecompletion.cpp 67a3033
>
> Diff: http://git.reviewboard.kde.org/r/104912/diff/
>
>
> Testing
> -------
>
> Checked it worked, the change is pretty simple.
>
>
> Thanks,
>
> Alexandre Courbot
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120522/b259b8b4/attachment.html>
More information about the KDevelop-devel
mailing list