Review Request: Let __builtin_offsetof be used with "struct foo" as type

[Alexandre Courbot]

> On May 16, 2012, 10:08 a.m., Milian Wolff wrote:
> > btw, do you have commit rights? if not, please request them:
> > 
> > http://techbase.kde.org/Contribute/Get_a_Contributor_Account
> > 
> > cheers, thanks for the good work!

Good idea, I just submitted my application (and you get to support it ;)). Probably the best thing to do since I have much more to submit anyway. Will commit this myself once I receive the necessary rights.

Thanks for the review!


- Alexandre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104912/#review13886
-----------------------------------------------------------


On May 14, 2012, 1:34 a.m., Alexandre Courbot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104912/
> -----------------------------------------------------------
> 
> (Updated May 14, 2012, 1:34 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> There is a clever macro defined that supports __builtin_offset, but constructs of the form "__builtin_offset(struct foo, member)" would fail with a parse error. This patch adds parentheses around the type to ensure these are supported as well.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/setuphelpers.cpp 23d549e 
>   languages/cpp/tests/test_cppcodecompletion.cpp 67a3033 
> 
> Diff: http://git.reviewboard.kde.org/r/104912/diff/
> 
> 
> Testing
> -------
> 
> Checked it worked, the change is pretty simple.
> 
> 
> Thanks,
> 
> Alexandre Courbot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120516/ab8ca246/attachment.html>