Review Request: FindQJSON.cmake: Look for parser.h in the right location.

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104925/#review13759
-----------------------------------------------------------


Just saw that QJson itself also installs a config-module in my version - 0.7.1. No idea when this was added and it is a rather basic file (i.e. hardcoded strings from the build), but it should be used if present.

Also that file suggests that finding the first qjson/ directory in your case would be the correct thing, which means you should be able to pass -DQJSON_INCLUDE_DIRS=/path/to/qjson/ to cmake to have it found.

- Andreas Pakulat


On May 12, 2012, 8:18 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104925/
> -----------------------------------------------------------
> 
> (Updated May 12, 2012, 8:18 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> QJSON headers are installed into qjson/qjson/<HEADER>.  The find_path()
> call, however, was looking for headers in qjson/<HEADER>, which failed.
> 
> Passing PATH_SUFFIX is not enough, and given how the headers are used in
> the code, we need to look for qjson/parser.h, not parser.h.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindQJSON.cmake 002084aefd8e2c1506a0674439cc37bc2539074b 
> 
> Diff: http://git.reviewboard.kde.org/r/104925/diff/
> 
> 
> Testing
> -------
> 
> qjson was not found here before, and it is after the patch is applied.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120513/2667dffa/attachment.html>