Review Request: FindQJSON.cmake: Look for parser.h in the right location.

[Andreas Pakulat]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104925/#review13758
-----------------------------------------------------------


Sorry, this is at least not enough. In debian parser.h is in /usr/include/qjson/ and the code using qjson builds here just fine, so the NAMES is correct for that distribution at least. Can you try just adding qjson/parser.h instead of replacing the existing entry?

- Andreas Pakulat


On May 12, 2012, 8:18 p.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104925/
> -----------------------------------------------------------
> 
> (Updated May 12, 2012, 8:18 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> QJSON headers are installed into qjson/qjson/<HEADER>.  The find_path()
> call, however, was looking for headers in qjson/<HEADER>, which failed.
> 
> Passing PATH_SUFFIX is not enough, and given how the headers are used in
> the code, we need to look for qjson/parser.h, not parser.h.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindQJSON.cmake 002084aefd8e2c1506a0674439cc37bc2539074b 
> 
> Diff: http://git.reviewboard.kde.org/r/104925/diff/
> 
> 
> Testing
> -------
> 
> qjson was not found here before, and it is after the patch is applied.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120513/63753759/attachment.html>