Review Request: Let __builtin_offsetof be used with "struct foo" as type

Alexandre Courbot gnurou at gmail.com
Fri May 11 05:33:03 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104912/
-----------------------------------------------------------

(Updated May 11, 2012, 5:33 a.m.)


Review request for KDevelop.


Description
-------

There is a clever macro defined that supports __builtin_offset, but constructs of the form "__builtin_offset(struct foo, member)" would fail with a parse error. This patch adds parentheses around the type to ensure these are supported as well.


Diffs
-----

  languages/cpp/setuphelpers.cpp 23d549e 

Diff: http://git.reviewboard.kde.org/r/104912/diff/


Testing
-------

Checked it worked, the change is pretty simple.


Thanks,

Alexandre Courbot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120511/a3520b5a/attachment.html>


More information about the KDevelop-devel mailing list