Review Request: Fixed some include directives (fixes a lot of krazy checks).

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104809/#review13333
-----------------------------------------------------------


sorry but this is completely wrong, actually that krazy check should be disabled.

thing is, we add the KDE folder via cmake to our include dirs, hence it's perfectly fine to just include <KUrl> instead of <KDE/KUrl>

furthermore, with Qt5 coming along, one should actually *not* use the <QtModule/QHeader> include style, but instead just <QHeader>

closing as discarded.

- Milian Wolff


On May 1, 2012, 2:32 p.m., Ghislain Mary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104809/
> -----------------------------------------------------------
> 
> (Updated May 1, 2012, 2:32 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Fixed some include directives (fixes a lot of krazy checks).
> 
> 
> Diffs
> -----
> 
>   debugger/interfaces/idebugsession.h 7310210 
>   debugger/interfaces/idebugsession.cpp 0b30295 
>   debugger/util/pathmappings.h 163c535 
>   debugger/util/treeview.cpp fad809e 
>   documentation/documentationfindwidget.h cde08d6 
>   documentation/standarddocumentationview.h eb07856 
>   interfaces/foregroundlock.h 04dfad7 
>   interfaces/ibuddydocumentfinder.h 7807df7 
>   interfaces/ipatchsource.h b38db33 
>   interfaces/iprojectprovider.h 6548335 
>   language/backgroundparser/documentchangetracker.h e3f7f5c 
>   language/codegen/createclass.h bf7bbe4 
>   language/codegen/overridespage.h e2a87c9 
>   language/duchain/indexedducontext.h d972202 
>   language/duchain/indexedtopducontext.h fb750c0 
>   language/duchain/referencecounting.h 13272f0 
>   language/duchain/safetycounter.h 4ee21b3 
>   language/duchain/stringhelpers.h 5af29d1 
>   language/duchain/topducontext.h 4f269ac 
>   language/editor/persistentmovingrange.h e131a0f 
>   language/util/debuglanguageparserhelper.h e851b0b 
>   plugins/appwizard/appwizarddialog.h c8a0c85 
>   plugins/appwizard/appwizardplugin.h 51333b1 
>   plugins/appwizard/projectselectionpage.h 745a1ef 
>   plugins/appwizard/projecttemplatesmodel.h cbd91e9 
>   plugins/dashboard/plasmoids/projectfileplasmoid/projectfileelement.h 8c8a71a 
>   plugins/documentview/kdevdocumentviewplugin.h 1cf9cfa 
>   plugins/executescript/iexecutescriptplugin.h 3c31d3c 
>   plugins/genericprojectmanager/test/reloadtest.h 26bc54c 
>   plugins/git/tests/initTest.h 3b58311 
>   plugins/grepview/grepviewplugin.h 91cffe9 
>   plugins/grepview/tests/findreplacetest.cpp ac0687d 
>   plugins/openwith/iopenwith.h b82c58d 
>   plugins/patchreview/libdiff2/tests/interactivedifftest.h 2b4294e 
>   plugins/projectmanagerview/projectbuildsetwidget.cpp 585a1c8 
>   plugins/snippet/snippet.h ab77646 
>   plugins/snippet/snippetfilterproxymodel.h 1c86d1c 
>   plugins/snippet/snippetplugin.h d7a85cf 
>   plugins/snippet/snippetrepository.h 29971a9 
>   plugins/snippet/snippetstore.h c938bd3 
>   plugins/standardoutputview/tests/standardoutputviewtest.cpp a06affd 
>   plugins/vcschangesview/vcschangesviewplugin.h a5c08d7 
>   project/abstractfilemanagerplugin.h cf027f5 
>   project/helper.h 63c74b3 
>   project/interfaces/ibuildsystemmanager.h c0813d8 
>   project/projectbuildsetmodel.h c37f6af 
>   project/projectitemlineedit.h 4d4e034 
>   shell/mainwindow_p.cpp 18ca6b5 
>   shell/partcontroller.h dfc4722 
>   tests/testfile.h 002f447 
>   tests/testhelpers.h 48bfe4c 
>   tests/testproject.h 6c000d5 
>   util/dbus_socket_transformer/main.cpp f3734b4 
>   util/environmentconfigurebutton.h e664b7c 
>   util/formattinghelpers.h d82d421 
>   util/processlinemaker.h 6a53922 
>   util/richtextpushbutton.h 6a91ca0 
>   util/richtexttoolbutton.h 17fb88b 
>   util/spinlock.h a3aa45c 
>   vcs/models/vcsfilechangesmodel.h 592327e 
>   vcs/models/vcsfilechangesmodel.cpp 3497d6c 
>   vcs/vcspluginhelper.cpp 0c6699f 
>   vcs/widgets/flexibleaction.h d09e22d 
>   vcs/widgets/vcslocationwidget.h ce580f0 
> 
> Diff: http://git.reviewboard.kde.org/r/104809/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ghislain Mary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120503/e66602df/attachment.html>