<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104809/">http://git.reviewboard.kde.org/r/104809/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">sorry but this is completely wrong, actually that krazy check should be disabled.
thing is, we add the KDE folder via cmake to our include dirs, hence it's perfectly fine to just include <KUrl> instead of <KDE/KUrl>
furthermore, with Qt5 coming along, one should actually *not* use the <QtModule/QHeader> include style, but instead just <QHeader>
closing as discarded.</pre>
<br />
<p>- Milian</p>
<br />
<p>On May 1st, 2012, 2:32 p.m., Ghislain Mary wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Ghislain Mary.</div>
<p style="color: grey;"><i>Updated May 1, 2012, 2:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed some include directives (fixes a lot of krazy checks).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debugger/interfaces/idebugsession.h <span style="color: grey">(7310210)</span></li>
<li>debugger/interfaces/idebugsession.cpp <span style="color: grey">(0b30295)</span></li>
<li>debugger/util/pathmappings.h <span style="color: grey">(163c535)</span></li>
<li>debugger/util/treeview.cpp <span style="color: grey">(fad809e)</span></li>
<li>documentation/documentationfindwidget.h <span style="color: grey">(cde08d6)</span></li>
<li>documentation/standarddocumentationview.h <span style="color: grey">(eb07856)</span></li>
<li>interfaces/foregroundlock.h <span style="color: grey">(04dfad7)</span></li>
<li>interfaces/ibuddydocumentfinder.h <span style="color: grey">(7807df7)</span></li>
<li>interfaces/ipatchsource.h <span style="color: grey">(b38db33)</span></li>
<li>interfaces/iprojectprovider.h <span style="color: grey">(6548335)</span></li>
<li>language/backgroundparser/documentchangetracker.h <span style="color: grey">(e3f7f5c)</span></li>
<li>language/codegen/createclass.h <span style="color: grey">(bf7bbe4)</span></li>
<li>language/codegen/overridespage.h <span style="color: grey">(e2a87c9)</span></li>
<li>language/duchain/indexedducontext.h <span style="color: grey">(d972202)</span></li>
<li>language/duchain/indexedtopducontext.h <span style="color: grey">(fb750c0)</span></li>
<li>language/duchain/referencecounting.h <span style="color: grey">(13272f0)</span></li>
<li>language/duchain/safetycounter.h <span style="color: grey">(4ee21b3)</span></li>
<li>language/duchain/stringhelpers.h <span style="color: grey">(5af29d1)</span></li>
<li>language/duchain/topducontext.h <span style="color: grey">(4f269ac)</span></li>
<li>language/editor/persistentmovingrange.h <span style="color: grey">(e131a0f)</span></li>
<li>language/util/debuglanguageparserhelper.h <span style="color: grey">(e851b0b)</span></li>
<li>plugins/appwizard/appwizarddialog.h <span style="color: grey">(c8a0c85)</span></li>
<li>plugins/appwizard/appwizardplugin.h <span style="color: grey">(51333b1)</span></li>
<li>plugins/appwizard/projectselectionpage.h <span style="color: grey">(745a1ef)</span></li>
<li>plugins/appwizard/projecttemplatesmodel.h <span style="color: grey">(cbd91e9)</span></li>
<li>plugins/dashboard/plasmoids/projectfileplasmoid/projectfileelement.h <span style="color: grey">(8c8a71a)</span></li>
<li>plugins/documentview/kdevdocumentviewplugin.h <span style="color: grey">(1cf9cfa)</span></li>
<li>plugins/executescript/iexecutescriptplugin.h <span style="color: grey">(3c31d3c)</span></li>
<li>plugins/genericprojectmanager/test/reloadtest.h <span style="color: grey">(26bc54c)</span></li>
<li>plugins/git/tests/initTest.h <span style="color: grey">(3b58311)</span></li>
<li>plugins/grepview/grepviewplugin.h <span style="color: grey">(91cffe9)</span></li>
<li>plugins/grepview/tests/findreplacetest.cpp <span style="color: grey">(ac0687d)</span></li>
<li>plugins/openwith/iopenwith.h <span style="color: grey">(b82c58d)</span></li>
<li>plugins/patchreview/libdiff2/tests/interactivedifftest.h <span style="color: grey">(2b4294e)</span></li>
<li>plugins/projectmanagerview/projectbuildsetwidget.cpp <span style="color: grey">(585a1c8)</span></li>
<li>plugins/snippet/snippet.h <span style="color: grey">(ab77646)</span></li>
<li>plugins/snippet/snippetfilterproxymodel.h <span style="color: grey">(1c86d1c)</span></li>
<li>plugins/snippet/snippetplugin.h <span style="color: grey">(d7a85cf)</span></li>
<li>plugins/snippet/snippetrepository.h <span style="color: grey">(29971a9)</span></li>
<li>plugins/snippet/snippetstore.h <span style="color: grey">(c938bd3)</span></li>
<li>plugins/standardoutputview/tests/standardoutputviewtest.cpp <span style="color: grey">(a06affd)</span></li>
<li>plugins/vcschangesview/vcschangesviewplugin.h <span style="color: grey">(a5c08d7)</span></li>
<li>project/abstractfilemanagerplugin.h <span style="color: grey">(cf027f5)</span></li>
<li>project/helper.h <span style="color: grey">(63c74b3)</span></li>
<li>project/interfaces/ibuildsystemmanager.h <span style="color: grey">(c0813d8)</span></li>
<li>project/projectbuildsetmodel.h <span style="color: grey">(c37f6af)</span></li>
<li>project/projectitemlineedit.h <span style="color: grey">(4d4e034)</span></li>
<li>shell/mainwindow_p.cpp <span style="color: grey">(18ca6b5)</span></li>
<li>shell/partcontroller.h <span style="color: grey">(dfc4722)</span></li>
<li>tests/testfile.h <span style="color: grey">(002f447)</span></li>
<li>tests/testhelpers.h <span style="color: grey">(48bfe4c)</span></li>
<li>tests/testproject.h <span style="color: grey">(6c000d5)</span></li>
<li>util/dbus_socket_transformer/main.cpp <span style="color: grey">(f3734b4)</span></li>
<li>util/environmentconfigurebutton.h <span style="color: grey">(e664b7c)</span></li>
<li>util/formattinghelpers.h <span style="color: grey">(d82d421)</span></li>
<li>util/processlinemaker.h <span style="color: grey">(6a53922)</span></li>
<li>util/richtextpushbutton.h <span style="color: grey">(6a91ca0)</span></li>
<li>util/richtexttoolbutton.h <span style="color: grey">(17fb88b)</span></li>
<li>util/spinlock.h <span style="color: grey">(a3aa45c)</span></li>
<li>vcs/models/vcsfilechangesmodel.h <span style="color: grey">(592327e)</span></li>
<li>vcs/models/vcsfilechangesmodel.cpp <span style="color: grey">(3497d6c)</span></li>
<li>vcs/vcspluginhelper.cpp <span style="color: grey">(0c6699f)</span></li>
<li>vcs/widgets/flexibleaction.h <span style="color: grey">(d09e22d)</span></li>
<li>vcs/widgets/vcslocationwidget.h <span style="color: grey">(ce580f0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104809/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>