Review Request: Remove VCS annotations on text change

[Milian Wolff]

> On April 1, 2011, 2:03 p.m., Milian Wolff wrote:
> > Nope this won't work imo. I'd rather have outdated info than no info as soon as I type something...
> > 
> > What do others say?
> 
> Andrey Batyiev wrote:
>     Bug's problem originates from Q_ASSERT in VcsAnnotationModel::revisionForLine( int line ) that checks correctness of line number in respect of annotation (i.e. line number is out of supposed annotation length => crash). As soon as you add extra line it would be possible to hit that assert.
>     Apart from hiding there are also ideas:
>     1. gray or otherwise mark annotations as outdated
>     2. modify annotations in obvious situations (line add/remove/edit) and do periodical updates
> 
> Milian Wolff wrote:
>     can you explain how to hit the assert? or didn't we disable it nowadays? anyhow, imo we should close this or is anyone else interested in this?

closing now


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100974/#review2296
-----------------------------------------------------------


On March 30, 2011, 5:18 p.m., Andrey Batyiev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100974/
> -----------------------------------------------------------
> 
> (Updated March 30, 2011, 5:18 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Whenever text in document is been changed (i.e. edited, checkouted, reverted etc), VCS annotations become invalid. Current state of VCS integration stuff makes impossible to update annotations on every key stroke, so this patch simply hides annotation bar.
> 
> 
> This addresses bug 269757.
>     http://bugs.kde.org/show_bug.cgi?id=269757
> 
> 
> Diffs
> -----
> 
>   vcs/vcspluginhelper.h 4b5b023 
>   vcs/vcspluginhelper.cpp e40e462 
> 
> Diff: http://git.reviewboard.kde.org/r/100974/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrey Batyiev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120316/10d44abc/attachment.html>