<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100974/">http://git.reviewboard.kde.org/r/100974/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 1st, 2011, 2:03 p.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nope this won't work imo. I'd rather have outdated info than no info as soon as I type something...
What do others say?</pre>
</blockquote>
<p>On April 2nd, 2011, 9:40 a.m., <b>Andrey Batyiev</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug's problem originates from Q_ASSERT in VcsAnnotationModel::revisionForLine( int line ) that checks correctness of line number in respect of annotation (i.e. line number is out of supposed annotation length => crash). As soon as you add extra line it would be possible to hit that assert.
Apart from hiding there are also ideas:
1. gray or otherwise mark annotations as outdated
2. modify annotations in obvious situations (line add/remove/edit) and do periodical updates</pre>
</blockquote>
<p>On June 25th, 2011, 10:10 a.m., <b>Milian Wolff</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">can you explain how to hit the assert? or didn't we disable it nowadays? anyhow, imo we should close this or is anyone else interested in this?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">closing now</pre>
<br />
<p>- Milian</p>
<br />
<p>On March 30th, 2011, 5:18 p.m., Andrey Batyiev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Andrey Batyiev.</div>
<p style="color: grey;"><i>Updated March 30, 2011, 5:18 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Whenever text in document is been changed (i.e. edited, checkouted, reverted etc), VCS annotations become invalid. Current state of VCS integration stuff makes impossible to update annotations on every key stroke, so this patch simply hides annotation bar.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=269757">269757</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>vcs/vcspluginhelper.h <span style="color: grey">(4b5b023)</span></li>
<li>vcs/vcspluginhelper.cpp <span style="color: grey">(e40e462)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100974/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>