Review Request: Bug 257703 - JJ: Please allow running executescript scripts from context menu in Projects

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104133/#review11076
-----------------------------------------------------------


I fear this might add lots of clutter, since you just put the actions into the parent menu and not into a sub menu. please change this and the other style issue, then I'm all for it.

thanks!


plugins/externalscript/externalscriptplugin.cpp
<http://git.reviewboard.kde.org/r/104133/#comment8947>

    static_cast will always "work" rather use this:
    
    ExternalScriptItem* item = dynamic_cast<>();
    Q_ASSERT(item);
    
    (and of course no if(item) {...})



plugins/externalscript/externalscriptplugin.cpp
<http://git.reviewboard.kde.org/r/104133/#comment8948>

    please add the actions into a sub menu:
    
    QMenu* menu = ...;
    
    for() {
      action = ...;
      menu->addAction(action);
    }
    
    ext.addAction( KDevelop::ContextMenuExtension::ExtensionGroup, menu->menuAction() );


- Milian Wolff


On March 1, 2012, 4:34 p.m., Ghislain Mary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104133/
> -----------------------------------------------------------
> 
> (Updated March 1, 2012, 4:34 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> List and enable execution of external scripts in the context menu of the files and projects views.
> 
> 
> This addresses bug 257703.
>     http://bugs.kde.org/show_bug.cgi?id=257703
> 
> 
> Diffs
> -----
> 
>   plugins/externalscript/CMakeLists.txt b1d6c004dd64095d5ee45229b6992636748d894d 
>   plugins/externalscript/externalscriptplugin.h fc9ee24fa719074e68a96c65b87d5bb4ae3e3dbe 
>   plugins/externalscript/externalscriptplugin.cpp 99231d84281da80e26ddec44a07f7a7492fdc0d0 
> 
> Diff: http://git.reviewboard.kde.org/r/104133/diff/
> 
> 
> Testing
> -------
> 
> Tested the execution of the external scripts being automatically added on first run of kdevelop (quick compile, google selection, sort selection) with several files being selected either in the files view or in the projects view.
> 
> 
> Thanks,
> 
> Ghislain Mary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120302/7895df09/attachment.html>