Review Request: Add nested view in the class browser plugin.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104932/#review14829
-----------------------------------------------------------


it looks to me as if you put the filtering into the model items which is ugly. Please use KRecursiveFilterProxyModel instead.


plugins/classbrowser/classwidget.h
<http://git.reviewboard.kde.org/r/104932/#comment11660>

    { on its own line please



plugins/classbrowser/classwidget.cpp
<http://git.reviewboard.kde.org/r/104932/#comment11661>

    please add that nested means path-based nesting


- Milian Wolff


On May 24, 2012, 2:08 p.m., Ghislain Mary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104932/
> -----------------------------------------------------------
> 
> (Updated May 24, 2012, 2:08 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> It enables the user to navigate the project tree and list the classes defined in each directory of the project.
> 
> Some more work would be needed after this to improve the search function. I think we should replace the search lineedit by a "Filter..." action as in the projectmanagerview plugin so it is more consistent. And then when the user enters a filter we should use automatically the flat view because otherwise the user will probably not see the result of his filtering.
> 
> 
> This addresses bug 212583.
>     http://bugs.kde.org/show_bug.cgi?id=212583
> 
> 
> Diffs
> -----
> 
>   plugins/classbrowser/classmodel.h fd1eed5 
>   plugins/classbrowser/classmodel.cpp f9956c6 
>   plugins/classbrowser/classmodelnode.h 739868b 
>   plugins/classbrowser/classmodelnode.cpp 334f424 
>   plugins/classbrowser/classwidget.h 1e1ed58 
>   plugins/classbrowser/classwidget.cpp f5a9517 
>   plugins/classbrowser/projectfolder.h d951a86 
>   plugins/classbrowser/projectfolder.cpp 419cb79 
> 
> Diff: http://git.reviewboard.kde.org/r/104932/diff/
> 
> 
> Testing
> -------
> 
> I used it on the kdevplatform and kdevelop sources and have seen no problem.
> 
> 
> Screenshots
> -----------
> 
> Nested view in class browser plugin
>   http://git.reviewboard.kde.org/r/104932/s/576/
> 
> 
> Thanks,
> 
> Ghislain Mary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120618/5d791b6f/attachment.html>