Review Request: Separate "directory is under CVS control" and "file is known/added" checking in CVS plugin

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105795/#review16652
-----------------------------------------------------------


This review has been submitted with commit 2613b89f6f8e800a8e544f7d401ea3e47f77775a by Ivan Shapovalov to branch 1.4.

- Commit Hook


On July 30, 2012, 2:43 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105795/
> -----------------------------------------------------------
> 
> (Updated July 30, 2012, 2:43 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Use different code to determine 1) whether the directory is under CVS control (used to show/hide CVS context menu) and 2) whether the file is known to CVS (Git's "in index") - used to enable or disable "Add"/"Revert" buttons.
> 
> Without this modification it is impossible to use "Add" in CVS plugins because isKnownDirectory() returned true for all files since they are _under_ a CVS-controlled directory.
> 
> 
> Diffs
> -----
> 
>   plugins/cvs/cvsproxy.h 6172239 
>   plugins/cvs/cvsproxy.cpp b21c624 
>   plugins/cvs/cvsplugin.cpp 984f38b 
> 
> Diff: http://git.reviewboard.kde.org/r/105795/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests + manual testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120730/d9fcdf28/attachment.html>