Review Request: Separate "directory is under CVS control" and "file is known/added" checking in CVS plugin

Ivan Shapovalov intelfx100 at
Mon Jul 30 14:43:07 UTC 2012

This is an automatically generated e-mail. To reply, visit:

Review request for KDevelop.


Use different code to determine 1) whether the directory is under CVS control (used to show/hide CVS context menu) and 2) whether the file is known to CVS (Git's "in index") - used to enable or disable "Add"/"Revert" buttons.

Without this modification it is impossible to use "Add" in CVS plugins because isKnownDirectory() returned true for all files since they are _under_ a CVS-controlled directory.


  plugins/cvs/cvsproxy.h 6172239 
  plugins/cvs/cvsproxy.cpp b21c624 
  plugins/cvs/cvsplugin.cpp 984f38b 



Existing unit-tests + manual testing.


Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list