Review Request: Separate "directory is under CVS control" and "file is known/added" checking in CVS plugin

Ivan Shapovalov intelfx100 at gmail.com
Mon Jul 30 14:43:07 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105795/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

Use different code to determine 1) whether the directory is under CVS control (used to show/hide CVS context menu) and 2) whether the file is known to CVS (Git's "in index") - used to enable or disable "Add"/"Revert" buttons.

Without this modification it is impossible to use "Add" in CVS plugins because isKnownDirectory() returned true for all files since they are _under_ a CVS-controlled directory.


Diffs
-----

  plugins/cvs/cvsproxy.h 6172239 
  plugins/cvs/cvsproxy.cpp b21c624 
  plugins/cvs/cvsplugin.cpp 984f38b 

Diff: http://git.reviewboard.kde.org/r/105795/diff/


Testing
-------

Existing unit-tests + manual testing.


Thanks,

Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120730/87bd1058/attachment.html>


More information about the KDevelop-devel mailing list