Review Request: Correctly handle non-zero exit code of "cvs diff"

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105792/#review16644
-----------------------------------------------------------

Ship it!


Good to see somebody caring about the CVS support! :)

- Aleix Pol Gonzalez


On July 30, 2012, 2:15 p.m., Ivan Shapovalov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105792/
> -----------------------------------------------------------
> 
> (Updated July 30, 2012, 2:15 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> CVS's "diff" command returns non-zero when there are changes against head (not when there are errors).
> There is a check for this condition (which checks job's output, and, if it's intact, rewrites job result for it to appear as successful), but process
> is still reported to user as failed ("Command finished with error <...>").
> 
> This change overrides error handling slot so it does nothing if output is OK.
> 
> 
> Diffs
> -----
> 
>   plugins/cvs/cvsdiffjob.h dbe7a7c 
>   plugins/cvs/cvsdiffjob.cpp 86a41cf 
>   vcs/dvcs/dvcsjob.h 775fe0a 
> 
> Diff: http://git.reviewboard.kde.org/r/105792/diff/
> 
> 
> Testing
> -------
> 
> Existing unit-tests + manual testing.
> 
> 
> Thanks,
> 
> Ivan Shapovalov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120730/ed56dbb7/attachment.html>