Review Request: Correctly handle non-zero exit code of "cvs diff"

Ivan Shapovalov intelfx100 at
Mon Jul 30 14:15:17 UTC 2012

This is an automatically generated e-mail. To reply, visit:

Review request for KDevelop.


CVS's "diff" command returns non-zero when there are changes against head (not when there are errors).
There is a check for this condition (which checks job's output, and, if it's intact, rewrites job result for it to appear as successful), but process
is still reported to user as failed ("Command finished with error <...>").

This change overrides error handling slot so it does nothing if output is OK.


  plugins/cvs/cvsdiffjob.h dbe7a7c 
  plugins/cvs/cvsdiffjob.cpp 86a41cf 
  vcs/dvcs/dvcsjob.h 775fe0a 



Existing unit-tests + manual testing.


Ivan Shapovalov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list