[kdevplatform] debugger/framestack: Improve the frame stack column sizes

[Andreas Pakulat]

Hi,

no testing done, but I think the problem is that the resizing always
happens. However right before there is a code-path which can lead to the
model being set to 0. If there's no model, there's also no header and hence
the mapping of logical to visual index will probably  yield an invalid
value. So I guess the right fix is to move the code into the if-branch.

Andreas

On Mon, Jul 16, 2012 at 4:12 PM, Andras Mantia <amantia at kde.org> wrote:

> Hi Aleix,
>
> On Monday, July 09, 2012 04:25:03 AM Aleix Pol wrote:
> > Git commit af7c5aecd6f43c9d023168077b3b6401dc6a43af by Aleix Pol.
> > Committed on 04/07/2012 at 00:05.
> > Pushed by apol into branch 'master'.
> >
> > Improve the frame stack column sizes
> >
> > Use a minimum size (contents) for the depth column in the frame stack
>
> This commit makes my KDevelop crash everytime I start the debugger (or
> attach
> to a process).
> It asserts in QHeaderView:
> [...]
> #8  0x00007fe26c167d63 in qt_message_output (msgType=QtFatalMsg,
> buf=0x481bbd8
> "ASSERT: \"visual != -1\" in file itemviews/qheaderview.cpp, line 1175") at
> global/qglobal.cpp:2260
> #9  0x00007fe26c167ed6 in qt_message(QtMsgType, const char *, typedef
> __va_list_tag __va_list_tag *) (msgType=QtFatalMsg, msg=0x7fe26c32a228
> "ASSERT: \"%s\" in file %s, line %d", ap=0x7fff4f8fb168) at
> global/qglobal.cpp:2306
> #10 0x00007fe26c168666 in qFatal (msg=0x7fe26c32a228 "ASSERT: \"%s\" in
> file
> %s, line %d") at global/qglobal.cpp:2489
> #11 0x00007fe26c167928 in qt_assert (assertion=0x7fe26b9d83a0 "visual !=
> -1",
> file=0x7fe26b9d8378 "itemviews/qheaderview.cpp", line=1175) at
> global/qglobal.cpp:2007
> #12 0x00007fe26b79804e in QHeaderView::setResizeMode (this=0x26cee30,
> logicalIndex=0, mode=QHeaderView::ResizeToContents) at
> itemviews/qheaderview.cpp:1175
> #13 0x00007fe26e1261b0 in KDevelop::FramestackWidget::currentThreadChanged
> (this=0x26c7e70, thread=-1) at
> /encrypted/home/andris/development/sources/kde-
> trunk/kdevplatform/debugger/framestack/framestackwidget.cpp:177
>
>
> See http://paste.kde.org/518228/.
>
> Andras
>
> >
> > M  +1    -0    debugger/framestack/framestackwidget.cpp
> >
> >
> http://commits.kde.org/kdevplatform/af7c5aecd6f43c9d023168077b3b6401dc6a43af
> >
> > diff --git a/debugger/framestack/framestackwidget.cpp
> > b/debugger/framestack/framestackwidget.cpp index 4b1025c..b3765da 100644
> > --- a/debugger/framestack/framestackwidget.cpp
> > +++ b/debugger/framestack/framestackwidget.cpp
> > @@ -174,6 +174,7 @@ void
> > KDevelop::FramestackWidget::currentThreadChanged(int thread)
> > m_threads->selectionModel()->clear();
> >          m_frames->setModel(0);
> >      }
> > +    m_frames->header()->setResizeMode(0, QHeaderView::ResizeToContents);
> >  }
> >
> >  void KDevelop::FramestackWidget::currentFrameChanged(int frame)
>
> --
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120716/117e2ea9/attachment.html>