Review Request: fix some untranslatable strings
Aleix Pol Gonzalez
aleixpol at gmail.com
Sun Jul 8 23:11:40 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105487/#review15555
-----------------------------------------------------------
Really good catches, I'm really sad we had such in our codebase still.
Please fix the patch with the changes I've proposed and I'll merge it ASAP.
language/duchain/navigation/usescollector.cpp
<http://git.reviewboard.kde.org/r/105487/#comment12159>
Here you should put the url as an argument:
i18n("%1 still needs an update!", ...)
plugins/grepview/grepoutputview.cpp
<http://git.reviewboard.kde.org/r/105487/#comment12160>
Remove all the QString().arg() to i18n.
i18n("...", name, prettyUrl, ...);
plugins/standardoutputview/outputwidget.cpp
<http://git.reviewboard.kde.org/r/105487/#comment12161>
Use "Search..."
- Aleix Pol Gonzalez
On July 8, 2012, 10:56 p.m., Gerhard Stengel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105487/
> -----------------------------------------------------------
>
> (Updated July 8, 2012, 10:56 p.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> This patch addresses some untranslatable strings in current kdevplatform master.
>
>
> Diffs
> -----
>
> debugger/variable/variablecollection.h 6340ae3
> debugger/variable/variablecollection.cpp 359f211
> language/duchain/navigation/usescollector.cpp f795015
> plugins/execute/nativeappconfig.cpp 19c34c2
> plugins/grepview/grepoutputview.cpp 3a1b454
> plugins/standardoutputview/outputwidget.cpp 3794308
>
> Diff: http://git.reviewboard.kde.org/r/105487/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gerhard Stengel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120708/f9ca571a/attachment.html>
More information about the KDevelop-devel
mailing list