<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105487/">http://git.reviewboard.kde.org/r/105487/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Really good catches, I'm really sad we had such in our codebase still.
Please fix the patch with the changes I've proposed and I'll merge it ASAP.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105487/diff/1/?file=71841#file71841line379" style="color: black; font-weight: bold; text-decoration: underline;">language/duchain/navigation/usescollector.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void UsesCollector::updateReady(KDevelop::IndexedString url, KDevelop::ReferencedTopDUContext topContext) {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">378</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ICore</span><span class="o">::</span><span class="n">self</span><span class="p">()</span><span class="o">-></span><span class="n">uiController</span><span class="p">()</span><span class="o">-></span><span class="n">showErrorMessage</span><span class="p">(</span><span class="n">ICore</span><span class="o">::</span><span class="n">self</span><span class="p">()</span><span class="o">-></span><span class="n">projectController</span><span class="p">()</span><span class="o">-></span><span class="n">prettyFileName</span><span class="p">(</span><span class="n">topContext</span><span class="o">-></span><span class="n">url</span><span class="p">().</span><span class="n">toUrl</span><span class="p">(),</span> <span class="n">KDevelop</span><span class="o">::</span><span class="n">IProjectController</span><span class="o">::</span><span class="n">FormatPlain</span><span class="p">)</span> <span class="o">+</span> <span class="s">" still needs an update!"</span><span class="p">,</span> <span class="mi">5</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">379</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ICore</span><span class="o">::</span><span class="n">self</span><span class="p">()</span><span class="o">-></span><span class="n">uiController</span><span class="p">()</span><span class="o">-></span><span class="n">showErrorMessage</span><span class="p">(</span><span class="n">ICore</span><span class="o">::</span><span class="n">self</span><span class="p">()</span><span class="o">-></span><span class="n">projectController</span><span class="p">()</span><span class="o">-></span><span class="n">prettyFileName</span><span class="p">(</span><span class="n">topContext</span><span class="o">-></span><span class="n">url</span><span class="p">().</span><span class="n">toUrl</span><span class="p">(),</span> <span class="n">KDevelop</span><span class="o">::</span><span class="n">IProjectController</span><span class="o">::</span><span class="n">FormatPlain</span><span class="p">)</span> <span class="o">+</span> <span class="n"><span class="hl">i18n</span></span><span class="p"><span class="hl">(</span></span><span class="s">" still needs an update!"</span><span class="p"><span class="hl">)</span>,</span> <span class="mi">5</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Here you should put the url as an argument:
i18n("%1 still needs an update!", ...)</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105487/diff/1/?file=71843#file71843line181" style="color: black; font-weight: bold; text-decoration: underline;">plugins/grepview/grepoutputview.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">GrepOutputModel* GrepOutputView::renewModel(QString name, QString descriptionOrUrl)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">181</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">displayName</span> <span class="o">=</span> <span class="n">QString</span><span class="p">(</span><span class="s">"Search %1 in %2 (at time %3)"</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">181</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QString</span> <span class="n">displayName</span> <span class="o">=</span> <span class="n">QString</span><span class="p">(</span><span class="n"><span class="hl">i18n</span></span><span class="p"><span class="hl">(</span></span><span class="s">"Search %1 in %2 (at time %3)"</span><span class="p">)<span class="hl">)</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove all the QString().arg() to i18n.
i18n("...", name, prettyUrl, ...);</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105487/diff/1/?file=71844#file71844line122" style="color: black; font-weight: bold; text-decoration: underline;">plugins/standardoutputview/outputwidget.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">OutputWidget::OutputWidget(QWidget* parent, ToolViewData* tvdata)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">122</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">filterInput</span><span class="o">-></span><span class="n">setClickMessage</span><span class="p">(</span><span class="s">"search..."</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">122</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">filterInput</span><span class="o">-></span><span class="n">setClickMessage</span><span class="p">(</span><span class="n"><span class="hl">i18n</span></span><span class="p"><span class="hl">(</span></span><span class="s">"search..."</span><span class="p">)<span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use "Search..."</pre>
</div>
<br />
<p>- Aleix</p>
<br />
<p>On July 8th, 2012, 10:56 p.m., Gerhard Stengel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Gerhard Stengel.</div>
<p style="color: grey;"><i>Updated July 8, 2012, 10:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch addresses some untranslatable strings in current kdevplatform master.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>debugger/variable/variablecollection.h <span style="color: grey">(6340ae3)</span></li>
<li>debugger/variable/variablecollection.cpp <span style="color: grey">(359f211)</span></li>
<li>language/duchain/navigation/usescollector.cpp <span style="color: grey">(f795015)</span></li>
<li>plugins/execute/nativeappconfig.cpp <span style="color: grey">(19c34c2)</span></li>
<li>plugins/grepview/grepoutputview.cpp <span style="color: grey">(3a1b454)</span></li>
<li>plugins/standardoutputview/outputwidget.cpp <span style="color: grey">(3794308)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105487/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>