Review Request: KDevelop: Use outputview/outputmodel

[Andreas Pakulat]

> On July 7, 2012, 4:54 p.m., Andreas Pakulat wrote:
> > Ship It!

Assuming you moved the unit-tests to the other patch


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105321/#review15519
-----------------------------------------------------------


On July 7, 2012, 11:13 a.m., Morten Volden wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105321/
> -----------------------------------------------------------
> 
> (Updated July 7, 2012, 11:13 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> This patch is related to: http://git.reviewboard.kde.org/r/104814/
> (Share code between makebuilder and external scripts). It uses the outputmodel defined in outputview/outputmodel and removes makeoutputmodel.
> 
> 
> Diffs
> -----
> 
>   projectbuilders/makebuilder/CMakeLists.txt 1674533 
>   projectbuilders/makebuilder/makebuilder.h 131324d 
>   projectbuilders/makebuilder/makebuilder.cpp b504a22 
>   projectbuilders/makebuilder/makejob.h 2cb7ef9 
>   projectbuilders/makebuilder/makejob.cpp 147dbfb 
>   projectbuilders/makebuilder/makeoutputdelegate.h a33a4ca 
>   projectbuilders/makebuilder/makeoutputdelegate.cpp 688ec3c 
>   projectbuilders/makebuilder/makeoutputmodel.h a088267 
>   projectbuilders/makebuilder/makeoutputmodel.cpp d2fdfb4 
>   projectbuilders/makebuilder/outputfilters.h 0b8b9d0 
>   projectbuilders/makebuilder/outputfilters.cpp 1017de0 
>   projectbuilders/makebuilder/tests/CMakeLists.txt bb16aca 
>   projectbuilders/makebuilder/tests/test_makeoutputmodel.h 0f5c8ce 
>   projectbuilders/makebuilder/tests/test_makeoutputmodel.cpp 5955c6b 
> 
> Diff: http://git.reviewboard.kde.org/r/105321/diff/
> 
> 
> Testing
> -------
> 
> Ported the tests from makeoutputmodel to outputview/outputmodel and outputview/filteringstrategies
> 
> 
> Thanks,
> 
> Morten Volden
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120707/3d2b9768/attachment.html>