Review Request: Fix '; ' placement after "create separate definition" action

Jonas Jacobi jonas.jacobi at web.de
Fri Jan 27 15:06:51 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103803/
-----------------------------------------------------------

Review request for KDevelop.


Description
-------

Move into source action currently places the ';' at the opening '{' of the function body, this patch places it at the end of the signature:
Before:
class X {
 void foo()
 {
 }
};
became
class X {
 void foo()
 ;
};

After:
class X {
 void foo()
 {
 }
};
becomes
class X {
 void foo();
};


Diffs
-----

  languages/cpp/codegen/simplerefactoring.cpp fd62ccf 

Diff: http://git.reviewboard.kde.org/r/103803/diff/diff


Testing
-------

Did some manual tests.
Tried to write automatic tests for some time, but it is atm not possible to test the moveintosource action, because it indirectly depends on "real files" being there.
I don't have the time to fix this in all relevant places, so no tests atm from me (there were no tests for the action before, too).


Thanks,

Jonas Jacobi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120127/c7e47527/attachment.html>


More information about the KDevelop-devel mailing list