Review Request: fix for '; ' placement after move into source action

Jonas Jacobi jonas.jacobi at web.de
Tue Jan 24 14:18:29 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103780/
-----------------------------------------------------------

(Updated Jan. 24, 2012, 2:18 p.m.)


Review request for KDevelop.


Changes
-------

Sorry for this mess, the 1st/2nd version of the diff were working, the third one not, so this is the 2nd version again.
The "braindead" do/while loop in it wasn't so braindead after all ;).


Description
-------

Move into source action currently places the ';' at the opening '{' of the function body, this patch places it at the end of the signature:
Before:
class X {
 void foo()
 {
 }
};
became
class X {
 void foo()
 ;
};

After:
class X {
 void foo()
 {
 }
};
becomes
class X {
 void foo();
};


Diffs (updated)
-----

  languages/cpp/codegen/simplerefactoring.cpp fd62ccf 

Diff: http://git.reviewboard.kde.org/r/103780/diff/diff


Testing
-------

works for me


Thanks,

Jonas Jacobi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120124/e7a95601/attachment.html>


More information about the KDevelop-devel mailing list