Review Request: bugfix for 227593. Kdevelop loads incorrectly folders with non-utf8 on CMake based projects.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103725/#review9920
-----------------------------------------------------------



projectmanagers/cmake/parser/cmakelistsparser.cpp
<http://git.reviewboard.kde.org/r/103725/#comment8201>

    Here maybe you're converting to Utf8 cases that's not needed?


Also, maybe you can extend some unit tests to make sure it works?

- Aleix Pol Gonzalez


On Jan. 18, 2012, 2:09 p.m., Tomaz  Canabrava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103725/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2012, 2:09 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> trying to fix bug - 227593. read CMakeLists as UTF8, so it read more characters than Latin-1.
> 
> 
> Diffs
> -----
> 
>   kdevelop.kdev4 023bd89 
>   projectmanagers/cmake/parser/cmakelistsparser.cpp ae5a641 
> 
> Diff: http://git.reviewboard.kde.org/r/103725/diff/diff
> 
> 
> Testing
> -------
> 
> created a stub project with greek and russian subfolders, everything loaded correctly.
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120118/cff2e465/attachment.html>