Review Request: Support for configurable generic filtering of project files (and directories)

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103554/#review9815
-----------------------------------------------------------


Hey, thanks for the ping - I completely missed this review request - I'm sorry!

Now though the current state of this patch is not to my likings I'm afraid:

- include/exclude patterns should be defineable on a per-project basis
- please take a look at GenericProjectManager::isValid and GenericProjectManagerPreferences for an existing solution albeit a very limited one (only for the generic manager). This should be made re-usable for other project managers and the project manager API extended such that it has a "isValid" or better-named function.

If you want to continue working on this, I would gladly review future patches and help out in this regard.

Cheers

- Milian Wolff


On Dec. 29, 2011, 3:33 p.m., Filip Brcic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103554/
> -----------------------------------------------------------
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Currently KDevPlatform and KDevelop filter only backup files from the project manager. It would be nicer if user could add additional files/directories to be filtered.
> 
> This patch adds a configurable stringlist that is to hold globs for files/directories that are to be filtered. Current default values are set to backup files (*~ and *.bak) and darcs repo data directory (_darcs).
> 
> How that looks like from the user side can be seen on the screenshot:
> 
> http://dl.dropbox.com/u/844580/kdevelop-filters/kdevelop-filtering.png
> 
> How that looks from the kdev* developer's side is this:
> 
> The stringlist is exposed through ProjectController as a method "QStringList filteredFiles() const". Of course, that method is also accessible through D-Bus interface IProjectController::filteredFiles(). It is left up to project managers to actually filter files, this method just provides a standardized list of files that are to be filtered (using regexp glob).
> 
> For previous discussion that lead to this patch, please take a look at https://git.reviewboard.kde.org/r/103549/
> 
> 
> Diffs
> -----
> 
>   interfaces/iprojectcontroller.h fd5638c 
>   shell/projectcontroller.h e21345f 
>   shell/projectcontroller.cpp e6eda6b 
>   shell/settings/projectconfig.kcfg a4d7a10 
>   shell/settings/projectsettings.ui d4ffdbd 
> 
> Diff: http://git.reviewboard.kde.org/r/103554/diff/diff
> 
> 
> Testing
> -------
> 
> I have patched kdevplatform and kdevelop 1.2.2 on my Gentoo box using this patch (and another patch for cmake project manager: http://dl.dropbox.com/u/844580/kdevelop-filters/kdevelop-generic_filter-1.diff) and filtering works fine.
> 
> 
> Thanks,
> 
> Filip Brcic
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120114/9185d8f9/attachment.html>