<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103554/">http://git.reviewboard.kde.org/r/103554/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hey, thanks for the ping - I completely missed this review request - I'm sorry!
Now though the current state of this patch is not to my likings I'm afraid:
- include/exclude patterns should be defineable on a per-project basis
- please take a look at GenericProjectManager::isValid and GenericProjectManagerPreferences for an existing solution albeit a very limited one (only for the generic manager). This should be made re-usable for other project managers and the project manager API extended such that it has a "isValid" or better-named function.
If you want to continue working on this, I would gladly review future patches and help out in this regard.
Cheers</pre>
<br />
<p>- Milian</p>
<br />
<p>On December 29th, 2011, 3:33 p.m., Filip Brcic wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Filip Brcic.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently KDevPlatform and KDevelop filter only backup files from the project manager. It would be nicer if user could add additional files/directories to be filtered.
This patch adds a configurable stringlist that is to hold globs for files/directories that are to be filtered. Current default values are set to backup files (*~ and *.bak) and darcs repo data directory (_darcs).
How that looks like from the user side can be seen on the screenshot:
http://dl.dropbox.com/u/844580/kdevelop-filters/kdevelop-filtering.png
How that looks from the kdev* developer's side is this:
The stringlist is exposed through ProjectController as a method "QStringList filteredFiles() const". Of course, that method is also accessible through D-Bus interface IProjectController::filteredFiles(). It is left up to project managers to actually filter files, this method just provides a standardized list of files that are to be filtered (using regexp glob).
For previous discussion that lead to this patch, please take a look at https://git.reviewboard.kde.org/r/103549/</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have patched kdevplatform and kdevelop 1.2.2 on my Gentoo box using this patch (and another patch for cmake project manager: http://dl.dropbox.com/u/844580/kdevelop-filters/kdevelop-generic_filter-1.diff) and filtering works fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>interfaces/iprojectcontroller.h <span style="color: grey">(fd5638c)</span></li>
<li>shell/projectcontroller.h <span style="color: grey">(e21345f)</span></li>
<li>shell/projectcontroller.cpp <span style="color: grey">(e6eda6b)</span></li>
<li>shell/settings/projectconfig.kcfg <span style="color: grey">(a4d7a10)</span></li>
<li>shell/settings/projectsettings.ui <span style="color: grey">(d4ffdbd)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103554/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>