Review Request: Save/Restore the ProjectTreeView. This enables a more seamless transition when returning to a project that was closed.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103619/#review9655
-----------------------------------------------------------

Ship it!


Two minor things, but all in all it's fine now - great work! I hope I didn't put you off too much with my nitpicky reviews ;-)

To land this patch in master, please *attach* the file created by "git format-patch". Uploading that file as diff will not allow me to use it for "git am". 

Thanks, I hope to see more patches from your side!


plugins/projectmanagerview/projecttreeview.cpp
<http://git.reviewboard.kde.org/r/103619/#comment7911>

    should be "projectmodelsaver.h"



shell/core.cpp
<http://git.reviewboard.kde.org/r/103619/#comment7912>

    please move it below the d->m_shuttingDown = true since in a slot attached to this signal I'd expect that the assertion ICore::shuttingDown() == true holds.


- Milian Wolff


On Jan. 9, 2012, 12:10 a.m., Andrew Fuller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103619/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2012, 12:10 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Save/Restore the ProjectTreeView.  This enables a more seamless transition when returning to a project that was closed.
> 
> 
> Diffs
> -----
> 
>   interfaces/icore.h 8bd579595c500b39ea8190c25cff38ba13e02630 
>   plugins/projectmanagerview/CMakeLists.txt 7b58e8e5489819b0370f5d55e0218f063da90af2 
>   plugins/projectmanagerview/projectmodelsaver.h PRE-CREATION 
>   plugins/projectmanagerview/projectmodelsaver.cpp PRE-CREATION 
>   plugins/projectmanagerview/projecttreeview.h 16893f0713b83a78a5b025a55fcfa082265d4419 
>   plugins/projectmanagerview/projecttreeview.cpp 8237af513627c0459d571de2bccc275e8a4b0ae9 
>   shell/core.cpp 587148fd4e77152af4608b91cd3423c5995c9996 
> 
> Diff: http://git.reviewboard.kde.org/r/103619/diff/diff
> 
> 
> Testing
> -------
> 
> Load a session, Exit, and return.  Voilà!  The tree is right where you left it.
> 
> 
> Thanks,
> 
> Andrew Fuller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120109/a3010cc9/attachment.html>