Review Request: Save/Restore the ProjectTreeView. This enables a more seamless transition when returning to a project that was closed.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103619/#review9653
-----------------------------------------------------------


first up: you are right about the ctor stuff, I was not sure how the maintainer is to be used. but thanks for moving that stuff to the plugin dir.

now though, I've found a new issue - sorry. please see below


plugins/projectmanagerview/CMakeLists.txt
<http://git.reviewboard.kde.org/r/103619/#comment7909>

    sorry, only now do I see the issue with this: plugins should not link against shell if possible, the sessioncontroller is not really considered public api
    
    note to self: I have to clean this up...
    
    so instead of using the sessioncontroller and adding a signal there, I'd guess it would be more useful to add this signal to icore.h and implement / emit it in core.cpp::cleanup(). call the signal aboutToShutDown or similar
    
    thanks - with this sorted out I'm fine with merging it finally I think.


- Milian Wolff


On Jan. 8, 2012, 6:59 p.m., Andrew Fuller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103619/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2012, 6:59 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Save/Restore the ProjectTreeView.  This enables a more seamless transition when returning to a project that was closed.
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/CMakeLists.txt 7b58e8e5489819b0370f5d55e0218f063da90af2 
>   plugins/projectmanagerview/projectmodelsaver.h PRE-CREATION 
>   plugins/projectmanagerview/projectmodelsaver.cpp PRE-CREATION 
>   plugins/projectmanagerview/projecttreeview.h 16893f0713b83a78a5b025a55fcfa082265d4419 
>   plugins/projectmanagerview/projecttreeview.cpp 8237af513627c0459d571de2bccc275e8a4b0ae9 
>   shell/sessioncontroller.h 551894d4131218b9ab2640e28f2c354ce319a105 
>   shell/sessioncontroller.cpp d2ee8732710e0e4bded56e547d83a3906b20b018 
> 
> Diff: http://git.reviewboard.kde.org/r/103619/diff/diff
> 
> 
> Testing
> -------
> 
> Load a session, Exit, and return.  Voilà!  The tree is right where you left it.
> 
> 
> Thanks,
> 
> Andrew Fuller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120108/3356248a/attachment.html>