Review Request: Save/Restore the ProjectTreeView. This enables a more seamless transition when returning to a project that was closed.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103619/#review9644
-----------------------------------------------------------


ok, a few more tidbits, then it's ready.

Oh and please take a look at http://api.kde.org/4.6-api/kdelibs-apidocs/kdeui/html/classKViewStateMaintainer.html - Steven (the author of both classes) told me that this is probably more useful for us. 


project/projectmodelsaver.cpp
<http://git.reviewboard.kde.org/r/103619/#comment7900>

    missing {}



shell/sessioncontroller.h
<http://git.reviewboard.kde.org/r/103619/#comment7899>

    please move the implementation to the .cpp file



shell/sessioncontroller.h
<http://git.reviewboard.kde.org/r/103619/#comment7898>

    please rename it to aboutToQuitSession()
    
    and maybe add a short comment explaining when this gets emitted and why it is useful


- Milian Wolff


On Jan. 7, 2012, 2:45 a.m., Andrew Fuller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103619/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2012, 2:45 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Save/Restore the ProjectTreeView.  This enables a more seamless transition when returning to a project that was closed.
> 
> 
> Diffs
> -----
> 
>   plugins/projectmanagerview/CMakeLists.txt 7b58e8e5489819b0370f5d55e0218f063da90af2 
>   plugins/projectmanagerview/projecttreeview.h 16893f0713b83a78a5b025a55fcfa082265d4419 
>   plugins/projectmanagerview/projecttreeview.cpp 8237af513627c0459d571de2bccc275e8a4b0ae9 
>   project/CMakeLists.txt bac4b22b8a9966f4efe4080a6d24e0de17c48e12 
>   project/projectmodelsaver.h PRE-CREATION 
>   project/projectmodelsaver.cpp PRE-CREATION 
>   shell/sessioncontroller.h 551894d4131218b9ab2640e28f2c354ce319a105 
>   shell/sessioncontroller.cpp d2ee8732710e0e4bded56e547d83a3906b20b018 
> 
> Diff: http://git.reviewboard.kde.org/r/103619/diff/diff
> 
> 
> Testing
> -------
> 
> Load a session, Exit, and return.  Voilà!  The tree is right where you left it.
> 
> 
> Thanks,
> 
> Andrew Fuller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120107/dd47196f/attachment.html>