kdevplatform textdocument.cpp

[Sven Brauch]

I find working sets unusable currently anyways. It's a great idea by
itself, but how is it supposed to be used? ;P
I can close a set of documents, but how can I open it again?
Also, those icons are really "developer icons". They are not an
acceptable solution for the final product, in my opinion. It'd be
better to label them "1", "2" etc. than using random icons.

Greetings

Am 29. Februar 2012 19:19 schrieb Milian Wolff <mail at milianw.de>:
> On Wednesday 29 February 2012 18:44:20 Milian Wolff wrote:
>> On Wednesday 29 February 2012 17:46:42 Milian Wolff wrote:
>> > On Tuesday 28 February 2012 23:35:16 Lambert CLARA wrote:
>> > > Hello,
>> > >
>> > > I noticed when working on my bookmarks patch that since 82cc03546384d,
>> > > TextDocument::close() method in shell/textdocument.cpp is not called
>> > > anymore when I close a file tab, but only when exitting kdevelop
>> > > completely. Was this intended ? i.e. should I find a new place for the
>> > > KTextEditor writeSessionConfig part of my patch :) ?
>> >
>> > yeah I think I have found out whats going on there and will show a patch
>> > soon (on reviewboard)
>>
>> scratch that, the whole working set code once again makes it nearly
>> impossible to track this down.
>>
>> But I have some news: We are really messing up the management of KatePart,
>> the document's are *leaked* until one closes KDevelop. Just look for
>> yourself:
>>
>> open kdevelop
>> attach gdb
>> set a breakpoint in KateDocument::~KateDocument
>> open a file in kdevelop
>> close it
>>
>> => breakpoint is *not* hit
>>
>> close kdevelop
>> -> break point is hit
>>
>> this is *really* a bad idea. A kate document *must* be closed as soon as
>> possible, otherwise will eat up your memory sooner rather than later...
>
> fixed the leak now, so funny that it's really just the deletion in the ctor
> like one would expect...
>
> all these "deleteLater" all over the place make this code really hard to work
> with and apparently also *very* fragile...
>
> I'd seriously welcome a cleanup of this code. I think it's time for me getting
> back at my work of cleaning up the workingset code and moving it into a
> plugin, thereby properly separating it of the core code... oh and did I
> mention unit tests?
>
> bye
> --
> Milian Wolff
> mail at milianw.de
> http://milianw.de
>
> --
> KDevelop-devel mailing list
> KDevelop-devel at kdevelop.org
> https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel