Review Request: Custom build system: Make multipath unittest pass
Milian Wolff
mail at milianw.de
Tue Feb 28 14:41:33 UTC 2012
> On Dec. 23, 2011, 10:27 p.m., Andreas Pakulat wrote:
> > Hmm, I wonder wether it might be better to compare the actual url's instead of their string-representation. Or does the test still fail when removing the .url from both sides?
you should use url.equals() with KUrl::CompareWithoutTrailingSlash
- Milian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103523/#review9223
-----------------------------------------------------------
On Dec. 23, 2011, 10:12 p.m., Morten Volden wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103523/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2011, 10:12 p.m.)
>
>
> Review request for KDevelop.
>
>
> Description
> -------
>
> Make multipath unittest pass
>
>
> Diffs
> -----
>
> tests/custombuildsystemplugintest.cpp ab2c861
>
> Diff: http://git.reviewboard.kde.org/r/103523/diff/
>
>
> Testing
> -------
>
> The test now passes
>
>
> Thanks,
>
> Morten Volden
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120228/4d917050/attachment.html>
More information about the KDevelop-devel
mailing list