Review Request: Fix '; ' placement after "create separate definition" action

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103803/#review10630
-----------------------------------------------------------


You could create a "real" file using TestFile. Opening a KTextEditor::Document for that (and maybe a view) should also give you the moving interface and hence the posibillity to write a unit test.

- Milian Wolff


On Jan. 27, 2012, 3:06 p.m., Jonas Jacobi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103803/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2012, 3:06 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Move into source action currently places the ';' at the opening '{' of the function body, this patch places it at the end of the signature:
> Before:
> class X {
>  void foo()
>  {
>  }
> };
> became
> class X {
>  void foo()
>  ;
> };
> 
> After:
> class X {
>  void foo()
>  {
>  }
> };
> becomes
> class X {
>  void foo();
> };
> 
> 
> Diffs
> -----
> 
>   languages/cpp/codegen/simplerefactoring.cpp fd62ccf 
> 
> Diff: http://git.reviewboard.kde.org/r/103803/diff/
> 
> 
> Testing
> -------
> 
> Did some manual tests.
> Tried to write automatic tests for some time, but it is atm not possible to test the moveintosource action, because it indirectly depends on "real files" being there.
> I don't have the time to fix this in all relevant places, so no tests atm from me (there were no tests for the action before, too).
> 
> 
> Thanks,
> 
> Jonas Jacobi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120214/b826d0cc/attachment.html>