<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103803/">http://git.reviewboard.kde.org/r/103803/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You could create a "real" file using TestFile. Opening a KTextEditor::Document for that (and maybe a view) should also give you the moving interface and hence the posibillity to write a unit test.</pre>
<br />
<p>- Milian</p>
<br />
<p>On January 27th, 2012, 3:06 p.m., Jonas Jacobi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDevelop.</div>
<div>By Jonas Jacobi.</div>
<p style="color: grey;"><i>Updated Jan. 27, 2012, 3:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Move into source action currently places the ';' at the opening '{' of the function body, this patch places it at the end of the signature:
Before:
class X {
void foo()
{
}
};
became
class X {
void foo()
;
};
After:
class X {
void foo()
{
}
};
becomes
class X {
void foo();
};</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did some manual tests.
Tried to write automatic tests for some time, but it is atm not possible to test the moveintosource action, because it indirectly depends on "real files" being there.
I don't have the time to fix this in all relevant places, so no tests atm from me (there were no tests for the action before, too).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>languages/cpp/codegen/simplerefactoring.cpp <span style="color: grey">(fd62ccf)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103803/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>