Review Request: Don't save/restore active area across restarts

[Niko Sams]

> On Jan. 22, 2012, 9:09 p.m., Andreas Pakulat wrote:
> > I disagree, at least for the review-area. Maybe its ok if the review area is not needed anymore (i.e. the patch is comitted, no local changes anymore), but then the user would've ended up in the code area anyway before closing kdevelop.
> > 
> > Maybe for the debug area kdevelop should rather start the debugee(s) that where left running again?
> 
> Aleix Pol Gonzalez wrote:
>     Hm... well for my perspective, these areas are places where you go to. Likewise, I never go from debug -> commit (even though it's possible).
>     Also I think it's not possible to restore the Patch Review state at the moment, so if you restore to Review, you get quite a useless screen (yes, I understand this patch is not fixing this, but it's a collateral effect).
>     
>     I think Niko's change makes sense. I wouldn't put it in 1.3 though, sounds more like a wish to me.
> 
> Niko Sams wrote:
>     Restoring as much as possible on restart is good. But restoring the debugger is impossible. Starting the debugee again could be done but would be to me - as a user - confusing if not irritating (what if the debugee triggers some unwanted action?)
>     
>     If restoring the review is possible I don't know. Also think about changed repositories, ie. when the users commited changes outside kdevelop.
> 
> Milian Wolff wrote:
>     I'm also with Niko here, don't restore the debugger. The review thingy though should not happen. so there I'm with apaku :)

But restoring the review isn't implemented!
Start a review by commiting (without actually committing) and restart kdevelop. You end up with an empty Patch Reivew Tool view.


- Niko


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103764/#review10010
-----------------------------------------------------------


On Jan. 22, 2012, 5:07 p.m., Niko Sams wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103764/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2012, 5:07 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Description
> -------
> 
> Areas are used in a workflow:
> - debugging
> - commiting/patch reviewing
> and kdevelop switches automatically to that area (and back)
> 
> Now when I have a running debug session (and debug area is opened) and I quit kdevelop, it will remember debug as active area and restore it on start.
> 
> That doesn't make much sense in the way areas are used now, so my patch removes that functionality.
> 
> ...ok to go into 1.3?
> 
> 
> Diffs
> -----
> 
>   shell/uicontroller.cpp 2091fdf 
> 
> Diff: http://git.reviewboard.kde.org/r/103764/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Niko Sams
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20120205/28d5e93e/attachment.html>